[dhcp_server] Add dhcp_server container #14031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
force-pushed
the
master_check_submodule
branch
10 times, most recently
from
c6961fa
to
48cd751
Compare
yaqiangz
force-pushed
the
master_check_submodule
branch
4 times, most recently
from
88a37b9
to
8ef454f
Compare
yaqiangz
force-pushed
the
master_check_submodule
branch
from
8ef454f
to
585da6a
Compare
yaqiangz
force-pushed
the
master_check_submodule
branch
2 times, most recently
from
eece0d2
to
4472b5d
Compare
yaqiangz
changed the title
yaqiangz
force-pushed
the
master_check_submodule
branch
from
4472b5d
to
087789c
Compare
yaqiangz
force-pushed
the
master_check_submodule
branch
from
9839962
to
f5448ef
Compare
Blueve
approved these changes
Sep 1, 2023
Blueve
approved these changes
Sep 7, 2023
yaqiangz
force-pushed
the
master_check_submodule
branch
from
baba096
to
52bfa2b
Compare
yaqiangz
added a commit
to yaqiangz/sonic-buildimage
that referenced
this pull request
Sep 12, 2023
Why I did it Add dhcp_server ipv4 feature to SONiC. HLD: sonic-net/SONiC#1282 How I did it To be clarify: This container is disabled by INCLUDE_DHCP_SERVER = n for now, which would cause container not build. Add INCLUDE_DHCP_SERVER to indicate whether to build dhcp_server container Add docker file for dhcp_server, build and install kea-dhcp4 inside container Add template file for dhcp_server container services. Add entry for dhcp_server to FEATURE table in config_db. How to verify it Build image with INCLUDE_DHCP_SERVER = y to verify: Image can be install successfully without crush. By config feature state dhcp_server enabled to enable dhcp_server.
sonic-otn
pushed a commit
to sonic-otn/sonic-buildimage
that referenced
this pull request
Sep 20, 2023
Why I did it Add dhcp_server ipv4 feature to SONiC. HLD: sonic-net/SONiC#1282 How I did it To be clarify: This container is disabled by INCLUDE_DHCP_SERVER = n for now, which would cause container not build. Add INCLUDE_DHCP_SERVER to indicate whether to build dhcp_server container Add docker file for dhcp_server, build and install kea-dhcp4 inside container Add template file for dhcp_server container services. Add entry for dhcp_server to FEATURE table in config_db. How to verify it Build image with INCLUDE_DHCP_SERVER = y to verify: Image can be install successfully without crush. By config feature state dhcp_server enabled to enable dhcp_server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Add dhcp_server ipv4 feature to SONiC.
HLD: sonic-net/SONiC#1282
Work item tracking
How I did it
To be clarify: This container is disabled by
INCLUDE_DHCP_SERVER = nfor now, which would cause container not build.INCLUDE_DHCP_SERVERto indicate whether to build dhcp_server containerFEATUREtable in config_db.How to verify it
Build image with
INCLUDE_DHCP_SERVER = yto verify:config feature state dhcp_server enabledto enable dhcp_server.Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)