[build] Refactor URLs used with dget #13302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumelambert
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
|
@saiarcot895 FYI |
guillaumelambert
force-pushed
the
dget
branch
2 times, most recently
from
0cea221
to
b792065
Compare
All other calls to dget use debian URLs rather than launchpad. It is logical since the target is to produce deb packages for debian systems and not Ubuntu. Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
dget retrieves sources and signatures to build deb packages from a URL poiting to a DSC file. The use of HTTPS is preferable to identify server endpoints and avoid potential MITM attacks. Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
guillaumelambert
force-pushed
the
dget
branch
from
b792065
to
343d728
Compare
guillaumelambert
added a commit
to guillaumelambert/sonic-buildimage
that referenced
this pull request
Jan 13, 2023
- create an a apt alternate configuration directory during 'make init' - use 'apt-get source' instead of dget in makefiles - adapt packages versions accordingly in rules/XX.mk files SONiC images compilation is currently designed to be performed with a non-root user under Ubuntu systems. As a result, there is no guarantee that debian repos are declared in /etc/apt/sources.list on the Ubuntu host system used. Although for this reason 'apt-get source' can not be directly used (out of the box) to that purpose, the build process recompiles packages for various GNU+Linux Debian distributions. And the packages sources used are retrieved from more or less official repositories since the current solution in SONiC is to use dget and URLs from various locations. As discussed in the following URL https://serverfault.com/questions/447457/use-apt-get-source-on-a-debian-repo-without-using-etc-apt-source-list this is the simplest solution but it has several drawbacks from a maintenance and security standpoint, for example : * maintaining manually these URLS since they can be removed by external sites owners sonic-net#13281 * potential loose authentication of packages sources sonic-net#13302 A more complex solution is prosposed (on the same URL) and adress these drawbacks by using an alternate apt configuration directory that is writable by non-root user. It allows here to: * identify packages sources with official Debian Keyring GPG signatures * use 'apt-get source <pkgsrc_name>' to retrieve packages without maintaining several specific URLs * in a next step use 'apt-cache showsrc <pkgsrc_name>' to retrieve a list of available versions to ckeck packages availability during the 'make init' phase Signed-off-by: Guillaume Lambert <guillaume.lambert@orange.com>
|
superseded by #13381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dget retrieves sources and signatures to build deb packages from a URL poiting to a DSC file.
The use of HTTPS is preferable to identify server endpoints and avoid potential MITM attacks.
All other calls to dget use debian URLs rather than launchpad.
It is logical since the target is to produce deb packages for debian systems and not Ubuntu.
Relates issue
#13281
Related PR
#13288
Which release branch to backport (provide reason below if selected)
all releases using these URLs
Description for the changelog
[build] Refactor URLs used with dget
A picture of a cute animal (not mandatory but encouraged)