-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[yang-models] Add YANG model for SYSTEM_PORT #12689
Merged
qiluo-msft
merged 6 commits into
sonic-net:master
from
kenneth-arista:master-system-port-yang
Feb 2, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
be3f9ec
[yang-models] Add YANG model for SYSTEM_PORT
kenneth-arista 3800179
Address review comments
kenneth-arista 30821a0
Revert ifname to string type to pass build
kenneth-arista d0201e0
Address review comments on yang model
kenneth-arista 9554f70
Added Configuration.md description for System Ports
kenneth-arista fd1d8d9
Fixed sonic-config-engine test failures
kenneth-arista File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/sonic-yang-models/tests/yang_model_tests/tests/system_port.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "SYSTEM_PORT_POSITIVE_CONFIG": { | ||
| "desc": "Configure SYSTEM_PORT positive config." | ||
| }, | ||
| "SYSTEM_PORT_WRONG_SPEED_PATTERN": { | ||
| "desc": "Configure SYSTEM_PORT wrong speed.", | ||
| "eStr": ["pattern", "does not satisfy"] | ||
| } | ||
| } |
91 changes: 91 additions & 0 deletions
91
src/sonic-yang-models/tests/yang_model_tests/tests_config/system_port.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| { | ||
| "SYSTEM_PORT_POSITIVE_CONFIG": { | ||
| "sonic-port:sonic-port": { | ||
| "sonic-port:PORT": { | ||
| "PORT_LIST": [ | ||
| { | ||
| "admin_status": "up", | ||
| "alias": "eth0", | ||
| "description": "Ethernet0", | ||
| "lanes": "65", | ||
| "mtu": 9000, | ||
| "name": "Ethernet0", | ||
| "speed": 100000 | ||
| }, | ||
| { | ||
| "admin_status": "up", | ||
| "alias": "eth4", | ||
| "description": "Ethernet4", | ||
| "lanes": "65", | ||
| "mtu": 9000, | ||
| "name": "Ethernet4", | ||
| "speed": 100000 | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "sonic-system-port:sonic-system-port": { | ||
| "sonic-system-port:SYSTEM_PORT": { | ||
| "SYSTEM_PORT_LIST": [ | ||
| { | ||
| "hostname": "host123", | ||
| "asic_name": "asic0", | ||
| "ifname": "Ethernet0", | ||
| "core_index": "0", | ||
| "core_port_index": "10", | ||
| "num_voq": "8", | ||
| "speed": "100000", | ||
| "switch_id": "0", | ||
| "system_port_id": "100" | ||
| }, | ||
| { | ||
| "hostname": "host123", | ||
| "asic_name": "asic1", | ||
| "ifname": "Ethernet4", | ||
| "core_index": "1", | ||
| "core_port_index": "20", | ||
| "num_voq": "8", | ||
| "speed": "100000", | ||
| "switch_id": "1", | ||
| "system_port_id": "200" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| }, | ||
| "SYSTEM_PORT_WRONG_SPEED_PATTERN": { | ||
| "sonic-port:sonic-port": { | ||
| "sonic-port:PORT": { | ||
| "PORT_LIST": [ | ||
| { | ||
| "admin_status": "up", | ||
| "alias": "eth0", | ||
| "description": "Ethernet0", | ||
| "lanes": "65", | ||
| "mtu": 9000, | ||
| "name": "Ethernet0", | ||
| "speed": 100000 | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| "sonic-system-port:sonic-system-port": { | ||
| "sonic-system-port:SYSTEM_PORT": { | ||
| "SYSTEM_PORT_LIST": [ | ||
| { | ||
| "hostname": "host456", | ||
| "asic_name": "asic0", | ||
| "ifname": "Ethernet0", | ||
| "core_index": "1", | ||
| "core_port_index": "20", | ||
| "num_voq": "8", | ||
| "speed": "900000", | ||
| "switch_id": "1", | ||
| "system_port_id": "200" | ||
| } | ||
| ] | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly point to the source of truth for config, e.g. HLD, Orchagent processing functions etc. Thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see
PortsOrch::addSystemPorts()in sonic-swss/orchagent/portsorch.cpp