Revert "[docker-teamd]: Manage teamd and teamsyncd processes with supervisor #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervisor (#1137)" This reverts commit a6edef2. The reason to revert this commit is that it breaks the current nightly test as no port channel interfaces are get created after boot. teamd failed to start and complained about 'Cannot allocate memory' possibly due to nlmsg_alloc function failure. Will revert this commit to investigate it further before moving to supervisor. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
stcheng
changed the title
lguohan
approved these changes
Nov 16, 2017
|
Sadly no further investigation results found 😢 |
|
The reason is mostly because the previous netdevs haven't been cleaned up! |
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jan 17, 2020
Submodule src/sonic-swss 49aff5da..e237e12d: > [aclorch] Validate that provided IN/OUT_PORTS are physical interfaces (sonic-net#1156) > Teamd :: fix for cleaning up the teamd processes correctly on teamd docker stop (sonic-net#1159) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Jan 29, 2020
4628a5a [vs tests] Refactor fdb_update tests to be consistent with vs test suite (#1185) 9594de0 Enable MIRRORv6 for BFN platform (#1177) a35afac [portsorch] use ingress/egress disable for LAG member enable/disable (#1166) faab3e1 remove the obsoleted platforms build links (#1169) 97abec5 [restore_neighbors.py] build arp packet with correct hwsrc and psrc (#1158) 97a22ca [vs tests] Mark VLAN and warm reboot tests as xfail (#1183) b453797 [Teamdmgrd]Fix "teamd cannot start when port channel was down before warm reboot" issue (#1171) 3732e74 [cfgmgr] clear loopback and vrf in kernel if not warmstart (#1141) 51315c1 [debugcounterorch] Add checks for supported counter types and drop reasons (#1173) 10f091d [vs tests] Disable NAT tests to unblock Jenkins (#1179) 698ca2a [portsorch] Refactor portsorch to use FlexCounterManager to setup port and queue stats (#1170) ea8b1da Merge pull request #1125 from AkhileshSamineni/natorch_changes_in_sonic bbd77fc Merge pull request #1126 from AkhileshSamineni/natsyncd_changes_in_sonic 419d9d2 Fix bug: shellquote the inner string (#1168) d507a93 [aclorch] Validate that provided IN/OUT_PORTS are physical interfaces (#1156) f24081b [AclOrch] add validation for check CRM (#1082) 85036df Merge pull request #1059 from AkhileshSamineni/nat_changes_in_sonic 1eac91e [portsorch] process PortsOrch tables in specific order (#1108) 80e01c0 Teamd :: fix for cleaning up the teamd processes correctly on teamd docker stop (#1159) 77fa5a4 Move away sairedis logrotate from signal handler (#1153) 5ad47af Merge branch 'master' into natorch_changes_in_sonic 982abd6 Fixed compilation issue after forced push. 286ca21 Fixed compilation issue. 3350b85 Added pytest testcases for NAT. 63ebb3a Added platform changes to avoid nexthop traching in OA. f9a8302 Addressed review comments. 946e53d Fixed compilation issue. 3d2b900 Addressed review comments and added 'nat miss' traps in copp json. ff2c78c Added changes to verify the NAT is supported before setting nat zone. 346f59a Addressed review comments. 8246acb Removed debug framework change to avoid compilation error f59ec87 Fixed compilation issue. e8b9dab Added aclorch changes for "do_not_nat" action. 88fe411 Orchagent changes in sonic-swss submodule to support NAT feature. 3ca530c Addressed review comments e4b7724 Addressed Review comments 72750ac Natsyncd changes in sonic-swss submodule to support NAT feature. 2086ad2 Fixed compilation issue after forced push. 3fcfea3 Fix in cleanup. 4028803 Added missed check ed405bf Addressed review comments ae6eb80 Compilation fix to pick proper ACL Table name - CFG_ACL_TABLE_TABLE_NAME d750132 Fix for string compilation issue 904e80b Corrected Makefile.am change. 5b09c41 Removed pytest related files and added those to PR #1125 fd733b8 Removed the Orchagent and Natsyncd related files as those are covered as part of PRs #1125 and #1126 b53c888 Loopback related changes for NAT. 29bb539 Added neighsync changes to support warm reboot for NAT. 4e0d0a1 Changes in sonic-swss submodule to support NAT feature. Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…sonic-net#1156) * [aclorch] Validate that provided IN/OUT_PORTS are physical interfaces - Add a check during the rule validation step to make sure provided IN/OUT_PORTS rules only include physical interfaces - Add vs test cases for invalid IN/OUT_PORTS inputs Signed-off-by: Danny Allen <daall@microsoft.com> * Clarify test names * Add extra delay for table teardown * Check if new tests are causing tests to fail * Check if new tests are causing tests to fail * Check if ProducerStateTable is having problems * Make delete ACL table test more strict * Remove invalid interface test cases * Undo change to delete test * Undo change to delete test
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
Jan 14, 2021
…sonic-net#1156) * [aclorch] Validate that provided IN/OUT_PORTS are physical interfaces - Add a check during the rule validation step to make sure provided IN/OUT_PORTS rules only include physical interfaces - Add vs test cases for invalid IN/OUT_PORTS inputs Signed-off-by: Danny Allen <daall@microsoft.com> * Clarify test names * Add extra delay for table teardown * Check if new tests are causing tests to fail * Check if new tests are causing tests to fail * Check if ProducerStateTable is having problems * Make delete ACL table test more strict * Remove invalid interface test cases * Undo change to delete test * Undo change to delete test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a6edef2.
The reason to revert this commit is that it breaks the current nightly test as
no port channel interfaces are get created after boot. teamd failed to start and
complained about 'Cannot allocate memory' possibly due to nlmsg_alloc function
failure.
Will revert this commit to investigate it further before moving to supervisor.
Signed-off-by: Shu0T1an ChenG shuche@microsoft.com