Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dell S6100: Addition of SFP type_abbrv_name field #10846

Merged
merged 3 commits into from
May 19, 2022

Conversation

aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented May 16, 2022

Why I did it

SFP mgmt-test case was failing in Dell S6100.

How I did it

Added type_abbrv_name to resolve the issue.

How to verify it

Execute SFP mgmt-test case and verify whether TC passes.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

UT log:
SFP_UT.txt
SFP mgmt TC:
test_sfp_log.txt

A picture of a cute animal (not mandatory but encouraged)

@aravindmani-1 aravindmani-1 marked this pull request as ready for review May 16, 2022 10:40
@prgeor prgeor self-assigned this May 16, 2022
@prgeor
Copy link
Contributor

prgeor commented May 17, 2022

@aravindmani-1 can you rebase your changes with latest from 202012 branch because there is a warning seen below

@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prgeor
Copy link
Contributor

prgeor commented May 17, 2022

@aravindmani-1 can you rebase?

@aravindmani-1
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aravindmani-1 aravindmani-1 force-pushed the dell_sfp_fix branch 2 times, most recently from d4cc8f3 to 7a5d7f1 Compare May 19, 2022 06:42
@prgeor prgeor merged commit cceef8e into sonic-net:202012 May 19, 2022
@aravindmani-1 aravindmani-1 deleted the dell_sfp_fix branch May 20, 2022 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants