-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dell S6100: Addition of SFP type_abbrv_name field #10846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prgeor
approved these changes
May 16, 2022
@aravindmani-1 can you rebase your changes with latest from 202012 branch because there is a warning seen below |
aravindmani-1
force-pushed
the
dell_sfp_fix
branch
from
May 17, 2022 05:09
cab402c
to
a7adc28
Compare
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
@aravindmani-1 can you rebase? |
aravindmani-1
force-pushed
the
dell_sfp_fix
branch
from
May 18, 2022 04:12
a7adc28
to
83a9d63
Compare
/azpw run Azure.sonic-buildimage |
/AzurePipelines run Azure.sonic-buildimage |
Azure Pipelines successfully started running 1 pipeline(s). |
aravindmani-1
force-pushed
the
dell_sfp_fix
branch
2 times, most recently
from
May 19, 2022 06:42
d4cc8f3
to
7a5d7f1
Compare
aravindmani-1
force-pushed
the
dell_sfp_fix
branch
from
May 19, 2022 10:26
7a5d7f1
to
beca326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
SFP mgmt-test case was failing in Dell S6100.
How I did it
Added type_abbrv_name to resolve the issue.
How to verify it
Execute SFP mgmt-test case and verify whether TC passes.
Which release branch to backport (provide reason below if selected)
Description for the changelog
UT log:
SFP_UT.txt
SFP mgmt TC:
test_sfp_log.txt
A picture of a cute animal (not mandatory but encouraged)