Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[portconfig]: Remove try block for db config initialization #10581

Merged
merged 6 commits into from
Apr 22, 2022
Merged

[portconfig]: Remove try block for db config initialization #10581

merged 6 commits into from
Apr 22, 2022

Commits on Apr 14, 2022

  1. Remove try block for loading global config db. 

    Fix unit-test case to read test from config db.

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
    @SuvarnaMeenakshi
    SuvarnaMeenakshi committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    a929919 View commit details
    Browse the repository at this point in the history

  2. Modify test case to retrieve data from config_db 

    as it was before PR sonic-net#10362.

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
    @SuvarnaMeenakshi
    SuvarnaMeenakshi committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    e70dfc7 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2022

  1. Revert "Modify test case to retrieve data from config_db" 

    This reverts commit e70dfc7.
    @SuvarnaMeenakshi
    SuvarnaMeenakshi committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    8fa9878 View commit details
    Browse the repository at this point in the history

  2. load db config in sonic-cfggen as suggested in pr review 

    to avoid loading db config in library like portconfig.py.

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
    @SuvarnaMeenakshi
    SuvarnaMeenakshi committed Apr 15, 2022
    Configuration menu
    Copy the full SHA
    8f26eb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. Fix lgtm error and fix load_db config function calls. 

    Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
    @SuvarnaMeenakshi
    SuvarnaMeenakshi committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    9f69333 View commit details
    Browse the repository at this point in the history

  2. Revert unit test changes. 

    Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
    @SuvarnaMeenakshi
    SuvarnaMeenakshi committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    13e94b8 View commit details
    Browse the repository at this point in the history