[dhcp6relay] Add dhcpv6 option check #10486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyyeh
force-pushed
the
dhcp6relay-payload
branch
from
c7c1e7f
to
d719413
Compare
kellyyeh
force-pushed
the
dhcp6relay-payload
branch
from
d719413
to
2c7927d
Compare
liat-grozovik
added
Request for 202012 Branch
Request for 202111 Branch
yxieca
reviewed
Apr 13, 2022
|
Add unit test? |
Noted |
yxieca
reviewed
Apr 25, 2022
src/dhcp6relay/src/relay.cpp
Outdated
| auto option = parse_dhcpv6_opt(option_position, &tmp); | ||
| option_position = tmp; | ||
| if(ntohs(option->option_code) > DHCPv6_OPTION_LIMIT) { | ||
| syslog(LOG_INFO, "DHCPv6 option is invalid or contains malformed payload\n"); |
There was a problem hiding this comment.
We should raise the log level to warning and add a counter for this.
yxieca
approved these changes
May 3, 2022
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
kellyyeh
added a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
May 11, 2022
(cherry picked from commit cfdb843)
6 tasks
kellyyeh
added a commit
to kellyyeh/sonic-buildimage
that referenced
this pull request
May 25, 2022
kellyyeh
added a commit
that referenced
this pull request
Jun 1, 2022
lguohan
pushed a commit
that referenced
this pull request
Jun 4, 2022
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jun 20, 2022
|
202012 branch PR merged: #10808 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To prevent relaying client packets with malformed payload
How I did it
Check for invalid dhcpv6 options
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)