Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-cfggen]: Update unit test to remove asn 0 #10454

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Apr 4, 2022

Signed-off-by: Gang Lv ganglv@microsoft.com

Why I did it

ASN range is from 1 to 4294967295, need to remove invalid ASN.

How I did it

Update unit test and replace ASN 0.

How to verify it

Run unit test for sonic-config-engine.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Fix #10363

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Gang Lv ganglv@microsoft.com
@ganglyu ganglyu added the sonic-cfggen SONiC Configuration Generator Tool label Apr 4, 2022
@ganglyu ganglyu requested a review from lguohan as a code owner April 4, 2022 05:42
@ganglyu ganglyu merged commit b152f2a into sonic-net:master Apr 6, 2022
@ganglyu ganglyu added the Request for 202111 Branch For PRs being requested for 202111 branch label Apr 14, 2022
judyjoseph pushed a commit that referenced this pull request Apr 18, 2022
Why I did it
ASN range is from 1 to 4294967295, need to remove invalid ASN.

How I did it
Update unit test and replace ASN 0.

How to verify it
Run unit test for sonic-config-engine.

Signed-off-by: Gang Lv ganglv@microsoft.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Included in 202111 Branch Request for 202111 Branch For PRs being requested for 202111 branch sonic-cfggen SONiC Configuration Generator Tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[yang] Invalid asn number
3 participants