[Mellanox] Refactor SFP to use new APIs. #10317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 8 alerts and fixes 9 when merging f687a9e into f8e1104 - view on LGTM.com new alerts:
fixed alerts:
|
6 tasks
keboliu
approved these changes
Mar 23, 2022
prgeor
approved these changes
Mar 23, 2022
|
@oleksandrivantsiv please specify which all transceiver types have been tested. Have you tested both DAC and Active cable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Refactor SFP code to remove code duplication and to be able to use the latest features available in new APIs.
How I did it
Refactor SFP code to remove code duplication and to be able to use the latest features available in new APIs.
How to verify it
Run sonic-mgmt/platform_tests/sfp tests
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)