[Marvell-armhf] Fixing issues related to partition label #10203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Icd5a867d22fa3e5e72ac1597f3e73430e8ca2675 Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
Change-Id: Ieb3e9c8821172c90e606b1209b2cef23a2dce271 Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
|
|
Blueve
added
the
Request for 202111 Branch
yxieca
approved these changes
Mar 10, 2022
|
@yxieca, some checks are failed but seems not related to the change from the PR. Can you please retrigger the tests and have this PR merged? Thank you. |
|
Thanks @yxieca. All checks are passed now. Can this PR be merged now please? |
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 25, 2022
Why I did it Removing incorrect check in plt setup for fw_env config: This check was added before to compare 2 different types of disk. Now the check is redundant and check is not required as transition is complete. 2)Removing legacy_volume_label in create_partition: legacy_volume_label is not used in armhf install files. With legacy_volume_label initialized to NULL, current code will always return true for check, if demo_part exits. How I did it Change is about removing the redundant/incorrect code explained above. How to verify it uboot fw_printenv and fw_setenv is tested onie-nos-install has be verified. Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
judyjoseph
pushed a commit
that referenced
this pull request
Mar 28, 2022
Why I did it Removing incorrect check in plt setup for fw_env config: This check was added before to compare 2 different types of disk. Now the check is redundant and check is not required as transition is complete. 2)Removing legacy_volume_label in create_partition: legacy_volume_label is not used in armhf install files. With legacy_volume_label initialized to NULL, current code will always return true for check, if demo_part exits. How I did it Change is about removing the redundant/incorrect code explained above. How to verify it uboot fw_printenv and fw_setenv is tested onie-nos-install has be verified. Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
2)Removing legacy_volume_label in create_partition: legacy_volume_label is not used in armhf install files. With legacy_volume_label initialized to NULL, current code will always return true for check, if demo_part exits.
How I did it
Change is about removing the redundant/incorrect code explained above.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Marvell-armhf: Fixing issues related to partition label
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)