[YANG ] Support vlan sub intf short naming format #10160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AZP run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
neethajohn
reviewed
Mar 8, 2022
src/sonic-yang-models/yang-models/sonic-vlan-sub-interface.yang
Outdated
Show resolved
Hide resolved
neethajohn
changed the title
lolyu
force-pushed
the
sub_intf_yang_shot_format
branch
from
45a4c04
to
3b0b57d
Compare
ganglyu
previously approved these changes
Mar 8, 2022
ganglyu
previously approved these changes
Mar 9, 2022
dgsudharsan
suggested changes
Mar 9, 2022
There was a problem hiding this comment.
Can you please add an example of short naming format here
https://github.com/Azure/sonic-buildimage/blob/d112e7cca9087d02892ada9d70bddcc5d5616c24/src/sonic-yang-models/tests/files/sample_config_db.json#L900
dgsudharsan
previously approved these changes
Mar 9, 2022
|
/AZP run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
neethajohn
previously approved these changes
Mar 11, 2022
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Mar 11, 2022
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/AZP run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/AZP run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp RUN |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
ganglyu
previously approved these changes
Mar 28, 2022
|
/AZP run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
lolyu
dismissed stale reviews from ganglyu, qiluo-msft, neethajohn, and dgsudharsan
via
64cb1c1
lolyu
force-pushed
the
sub_intf_yang_shot_format
branch
from
e3ff540
to
64cb1c1
Compare
|
I've rebased this PR to the newest master branch, all the approvals are dismissed. Could you please help review again, thanks! @neethajohn @ganglyu @qiluo-msft |
ganglyu
approved these changes
Mar 30, 2022
qiluo-msft
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
To support vlan sub intf short naming format, like subport
Eth8.100for parent portEthernet8with vlan id100.How I did it
Add checks to
mustcondition to verify there is a port or portchannel with the index same as the vlan sub intf.How to verify it
Run the unttests.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)