Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[yang] Need Yang for BGP_INTERNAL_NEIGHBOR table #10157

Closed
ganglyu opened this issue Mar 7, 2022 · 2 comments · Fixed by #10632
Closed

[yang] Need Yang for BGP_INTERNAL_NEIGHBOR table #10157

ganglyu opened this issue Mar 7, 2022 · 2 comments · Fixed by #10632
Assignees
@arlakshm
Labels
Triaged this issue has been triaged YANG YANG model related changes

Comments

@ganglyu
Copy link
Contributor

ganglyu commented Mar 7, 2022

Description

We don't have yang model about BGP_INTERNAL_NEIGHBOR table.
Please refer to sonic-net/sonic-utilities#2029

Steps to reproduce the issue:

Describe the results you received:

Describe the results you expected:

Output of show version:

(paste your output here)

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):
@ganglyu ganglyu added the YANG YANG model related changes label Mar 7, 2022
@ganglyu ganglyu mentioned this issue Mar 7, 2022
Closed
@ganglyu
Copy link
Contributor Author

ganglyu commented Mar 7, 2022

@jmmikkel Can you add Yang for BGP_INTERNAL_NEIGHBOR table?

@jmmikkel
Copy link
Contributor

jmmikkel commented Apr 5, 2022

I had nothing to do with this table. If you are going to dig up the people who originally added the tables, this needs someone else.

@arlakshm arlakshm mentioned this issue Apr 20, 2022
Merged
6 tasks
@zhangyanzhao zhangyanzhao added the Triaged this issue has been triaged label Apr 28, 2022
arlakshm added a commit that referenced this issue May 4, 2022
@arlakshm
[yang][multi-asic]bgp internal neighbor yang model (#10632)
288d667 
closes #10157

Why I did it
Add yang model for the bgp_internal_neighbor table in config_db

How I did it
Add new yang model file and unit tests

How to verify it
UT and compile sonic_yang_models-1.0-py3-none-any.whl and sonic_yang_mgmt-1.0-py3-none-any.whl

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this issue Jun 20, 2022
@arlakshm @liushilongbuaa
[yang][multi-asic]bgp internal neighbor yang model (sonic-net#10632)
00ed2ce 
closes sonic-net#10157

Why I did it
Add yang model for the bgp_internal_neighbor table in config_db

How I did it
Add new yang model file and unit tests

How to verify it
UT and compile sonic_yang_models-1.0-py3-none-any.whl and sonic_yang_mgmt-1.0-py3-none-any.whl

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <arlakshm@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arlakshm arlakshm

Labels
Triaged this issue has been triaged YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Yang]: bgp internal neighbor yang model arlakshm/sonic-buildimage
4 participants
@zhangyanzhao @arlakshm @jmmikkel @ganglyu