Merged EVPN VxLAN MH HLD from Cisco and BCM #1702

pbrisset · 2024-05-21T16:49:41Z

This is the result of merging Cisco and BCM HLDs.

Cisco HLD
BCM HLD

prvattem · 2024-05-31T00:55:16Z

@adyeung please add me to the reviewers list?

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

prvattem · 2024-06-13T23:19:23Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+#### 1.2.1.2 L2 Unicast forwarding in EVPN MH
+The control-plane and forwarding-plane handling of MAC and local adjacency (ARP/ND) learnt on the Multihomed Ethernet-Segments significantly differs from the single homed Ethernet-Segments in the EVPN VxLAN network.
+
+Each VTEP advertises EVPN Type-1 (per ES/EAD) route per local Ethernet-Segment. These VTEPs also advertises EVPN Type-2 (MAC/IP) route per locally learn adjacency (ARP/ND). Remote VTEPs perform EVPN route resolution based on matching ESI value carried as part of these routes. For each Ethernet-Segment, an unique L2 Next-hop group (NHG) is formed that contains the participating VTEPs. All processed EVPN Type-2 routes are pointing to that L2 NHG on matching ESI.


Could you please add a section to capture new BGP EVPN routes(Type-1 and Type-4) being supported?

Route-type 1 and 4 works as described in RFC7432. No need to add them here explicitely.

AntonButenkoGL

Hello @pbrisset

I represent a team working on the EVPN Multihoming implementation and we found some comments to this PR.

Can you, please, check the comments? We think they are crucial to have the implementation.

Thank you

AntonButenkoGL · 2024-06-27T20:36:24Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+**EVPN_ETHERNET_SEGMENT**
+
+```
+;New table
+;Specifies EVPN Ethernet Segment interface
+;
+; Status: stable
+key = EVPN_ETHERNET_SEGMENT|"ifname"if_id
+; field = value
+esi        = "AUTO"  or es_id
+                ; es_id is 10 byte colon (:) separated string when type = "TYPE_0_OPERATOR_CONFIGURED".
+                ; Otherwise, esi value should be "AUTO" falling back on ESI type 1 or 3.
+type       = esi_type
+                ; esi_type should be string with one of the below values:
+                ; "TYPE_0_OPERATOR_CONFIGURED" for Type-0 ESI
+                ; "TYPE_1_LACP_BASED" for Type-1 ESI
+                ; "TYPE_3_MAC_BASED" for Type-3 ESI
+ifname     = "ifname"if_id
+                ; if_id is the interface identifier. Same value as in the key.
+                ; e.g., PortChannel1, where the ifname is PortChannel and the if_id is 1.
+df_pref    = 1*5DIGIT
+                ; Designated-Forwarder election preference for this router in (1..65535) range.
+                ; Default=32767.
+```


EVPN_ETHERNET_SEGMENT table does not map on existing FRR commands and is missing required functionality: mac and id for type-3 ESI. Those 2 items are both mandatory in FRR for type-3 ES to work. Also to our knowledge there is no type-1 ESI support in FRR right now or in any PR. So even if everything else is ready to resolve ESI through LACP, FRR is not ready at all.

We dont care about ESI value in SONIC. FRR using the Ethernet Segment info programs needed DB in SONIC such as SHL, DF/NDF, etc.

AntonButenkoGL · 2024-06-27T20:42:19Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+curl -X PATCH "https://SWICH_IP:9090/restconf/data/openconfig-network-instance:network-instances/network-instance=default/evpn/evpn-mh/config" -H "accept: */*" -H "Content-Type: application/yang-data+json" -d "{\"openconfig-network-instance:config\":{\"startup-delay\":150,\"mac-holdtime\":200,\"neigh-holdtime\":250}}" 
+```
+<a id="4-Flow-Diagrams"></a>
+# 4 Flow Diagrams


The Flow Diagrams section contains multiple distinctly different ways of to naming/implementing feature comparing to the rest of the document. We think these diagrams are outdated artifacts from #1638 requirements and contradict the new requirements.

hummm. Can you be explicit?

AntonButenkoGL · 2024-06-27T20:45:45Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+### 3.3.8 L2nhgorch
+- New Orchagent class being introduced.
+- Subscription to different tables
+  - APP DB - L2_NEXTHOP_GROUP, L2_NEXTHOP_GROUP_MEMBER
+  - CONFIG DB - EVPN_ES_INTERFACE.
+- Subscription to L2_NEXTHOP_GROUP
+  - Creates/deletes the L2_ECMP_GROUP ASIC DB table.
+  - Interacts with PortsOrch to create a bridge-port object of type L2_ECMP_GROUP.
+- Subscription to L2_NEXTHOP_GROUP_MEMBER
+  - Creates/deletes the L2_ECMP_GROUP_MEMBER ASIC DB tables entries on the L2_NEXTHOP_GROUP APP DB table updates.


The "DB Changes" and "Impact to existing modules" section conflicts with the L2_NEXTHOP_GROUP schema in APP_DB (the latter mentions a separate table for members). We propose that the one in "DB Changes" section is to be chosen as the correct approach and "L2nhgorch" subsection is to be rewritten accordingly.

Text was updated. You may want to re-review this section.

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

gord1306 · 2024-07-12T08:57:32Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+### 2.2.4 Linux Kernel Support
+EVPN Multihoming feature requires L2 next-hop group (NHG) support in the Linux kernel that is available in v5.10.
+EVPN Multihoming feature will not be supported in SONiC releases running 4.x kernel versions.
+


According to RFC 8365, Section 8.3.3

VXLAN-GPE encapsulation needs to be used between these PEs and the ingress PE needs to set the BUM Traffic Bit (B bit) to indicate that this is an ingress-replicated BUM traffic.

It might need an additional patch to support this in the v5.10??

@AntonButenkoGL @pbrisset Does the kernel v5.10 need patch for this?

SONiC is currently at Linux kernel v6.1.38.

Is the BUM Traffic Bit already supported by Linux Kernel v6.1.38?

gord1306 · 2024-07-12T15:50:47Z

In the current implementation, can all the functionalities already work on the VS (virtual machine) platform?

AntonButenkoGL · 2024-07-12T16:00:04Z

In the current implementation, can all the functionalities already work on the VS (virtual machine) platform?

Yes, it was tested with VS platform.
Additionally, SAG and WarmReboot use cases testing is in progress.

And there is a work in progress to align the ESI types logic with the current requirements.

Updated kernel, SAI, config, and design sections

Update EVPN_VxLAN_Multihoming.md

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

…omments

venkatmahalingam · 2024-07-30T19:59:59Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+;Specifies EVPN Ethernet Segment interface
+;
+; Status: stable
+key = EVPN_ETHERNET_SEGMENT|"ifname"if_id


"ifname"if_id looks weird, can we just have an ifname as key and in the description, it's already mentioned about if_id. Same suggestion for other cases like "Vlan"vlan_id as well.

venkatmahalingam · 2024-07-30T20:02:41Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+The Isolation group SAI object used for achieving Local Bias and Split Horizon Filtering in the MCLAG will be reused for EVPN MH. In EVPN MH an Isolation group for every Peer Multihoming VTEP is created as opposed to a single group for MCLAG. The Isolation group members are populated based on the EVPN_SPLIT_HORIZON_TABLE APP-DB entry. Traffic received from the Tunnel towards the peer multihoming VTEP will not be forwarded to the members of the Isolation group.
+
+<a id="224-Linux-Kernel-Support"></a>
+### 2.2.4 Linux Kernel Support


Can SONiC-VM work for MH feature any without limitations/restriction?

venkatmahalingam · 2024-07-30T20:06:40Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+Configuration handling of MCLAG should now be aware of EVPN Ethernet-Segment configurations and throw appropriate errors in order to achieve mutual-exclusion between EVPN Multihoming and MCLAG features.
+OpenConfig evpn yang is imported into SONiC and ethernet-segment URIs are implemented.
+OpenConfig LACP yang already has system-id-mac configuration and it will be implemented.
+OpenConfig evpn yang will be extended for global non-standard parameter configurations (e.g. MAC/ARP hold-timer, etc.)


We dont have openconfig support for EVPN feature as such in the SONiC community, are we planning to bring that support via mgmt-framework as part of EVPN MH effort?

zhangyanzhao · 2024-08-06T15:08:39Z

sonic community review recording on 7/30 https://zoom.us/rec/share/V2Xv_D2UOXdjLKJHazb1AV11JQxEsXS6275dtFiGA_QyGPgoVvWmL0lh9A5DJBfE.l-gvQEzam4TFRpXT

helloanandhi · 2024-08-13T15:10:56Z

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md

+##### 1.2.1.1.1 Local-bias and split-horizon filtering
+In multi-homed scenario, if the BUM traffic originates from a device attached to an EVPN Ethernet-Segment, local-bias procedure is applied and BUM traffic is flooded on all locally attached multi-homed and single-homed devices. The BUM traffic is also replicated to the remote VTEPs, and split-horizon filtering is applied such that traffic is not replicated to any of the devices that are attached to the shared EVPN Ethernet-Segment.
+
+Local-bias procedure is described in EVPN VxLAN Overlay [RFC 8365](https://datatracker.ietf.org/doc/html/rfc8365). The behavior of local-bias is explained with the help of below diagram.


What is the VXLAN encapsulation type used for BUM traffic indication ?

Is it going to be VXLAN-GPE tunnel type ?

If yes, is there any extension planned for sai_tunnel_type_t ?

pbrisset and others added 4 commits May 21, 2024 12:49

Merged EVPN VxLAN MH HLD from Cisco and BCM

c4d56ce

updating the Revision section

c7916ae

Adding Figure # to the document

4907208

adding back the revision

33bec5c

adyeung requested review from srj102, Praveen-Brcm and hasan-brcm May 30, 2024 21:27

adyeung requested a review from prvattem May 31, 2024 23:31

prvattem reviewed Jun 13, 2024

View reviewed changes

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md Show resolved Hide resolved

prvattem reviewed Jun 13, 2024

View reviewed changes

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md Show resolved Hide resolved

prvattem reviewed Jun 13, 2024

View reviewed changes

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md Outdated Show resolved Hide resolved

prvattem reviewed Jun 13, 2024

View reviewed changes

updated show commands and their outputs

7b5821e

Yuval-Mellanox requested a review from eddyk-nvidia June 24, 2024 06:19

This was referenced Jun 26, 2024

EVPN VxLAN Multihoming HLD #1622

Closed

EVPN-VxLAN Multihoming HLD #1638

Closed

AntonButenkoGL suggested changes Jun 27, 2024

View reviewed changes

pbrisset added 2 commits July 4, 2024 12:05

Creating the host learning HLD for VOQ architecture

9f839fb

undo hld commit

1885f52

gord1306 reviewed Jul 12, 2024

View reviewed changes

hasan-brcm and others added 3 commits July 29, 2024 15:35

Update EVPN_VxLAN_Multihoming.md

6dfba05

Updated kernel, SAI, config, and design sections

Merge pull request #1 from hasan-brcm/patch-1

542b178

Update EVPN_VxLAN_Multihoming.md

updating VxLAN MH

685c0af

venkatmahalingam reviewed Jul 30, 2024

View reviewed changes

doc/vxlan/EVPN/EVPN_VxLAN_Multihoming.md Show resolved Hide resolved

Updated SAI examples, adding ShlOrchagent definition, addressing PR c…

3cf7a5c

…omments

venkatmahalingam reviewed Jul 30, 2024

View reviewed changes

Updated SAI examples

d80bbed

helloanandhi reviewed Aug 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merged EVPN VxLAN MH HLD from Cisco and BCM #1702

Merged EVPN VxLAN MH HLD from Cisco and BCM #1702

pbrisset commented May 21, 2024 •

edited

Loading

prvattem commented May 31, 2024

prvattem Jun 13, 2024

pbrisset Jun 14, 2024 •

edited

Loading

AntonButenkoGL left a comment

AntonButenkoGL Jun 27, 2024

pbrisset Jul 30, 2024

AntonButenkoGL Jun 27, 2024

pbrisset Jul 30, 2024

AntonButenkoGL Jun 27, 2024

pbrisset Jul 30, 2024

gord1306 Jul 12, 2024

gord1306 Jul 22, 2024

pbrisset Jul 30, 2024

gord1306 Aug 2, 2024

gord1306 commented Jul 12, 2024

AntonButenkoGL commented Jul 12, 2024 •

edited

Loading

venkatmahalingam Jul 30, 2024 •

edited

Loading

venkatmahalingam Jul 30, 2024

venkatmahalingam Jul 30, 2024

zhangyanzhao commented Aug 6, 2024

helloanandhi Aug 13, 2024

Merged EVPN VxLAN MH HLD from Cisco and BCM #1702

Are you sure you want to change the base?

Merged EVPN VxLAN MH HLD from Cisco and BCM #1702

Conversation

pbrisset commented May 21, 2024 • edited Loading

prvattem commented May 31, 2024

Choose a reason for hiding this comment

pbrisset Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

AntonButenkoGL left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gord1306 commented Jul 12, 2024

AntonButenkoGL commented Jul 12, 2024 • edited Loading

venkatmahalingam Jul 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhangyanzhao commented Aug 6, 2024

Choose a reason for hiding this comment

pbrisset commented May 21, 2024 •

edited

Loading

pbrisset Jun 14, 2024 •

edited

Loading

AntonButenkoGL commented Jul 12, 2024 •

edited

Loading

venkatmahalingam Jul 30, 2024 •

edited

Loading