Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix catchError propagation #2227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mdynnl
Copy link
Contributor

@mdynnl mdynnl commented Jul 18, 2024

Summary

Opening this up just for the idea. I initially used a separate const ErrorHandled = Symbol() but changed to ERROR.

fixes #1895

IMO, catchError should work like one we have in the language. It should stop further execution inside the boundary. Everything outside should work as usual.
https://playground.solidjs.com/anonymous/a42cb5b3-37b9-4469-9b48-a5fc0d50937e

How did you test this change?

Added a narrowed down test for catchError though I'm not sure if there's any other edge cases.
pnpm test seems to pass including the one added.

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: bd54cec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9997429348

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 93.602%

Totals Coverage Status
Change from base Build 9751531446: 0.04%
Covered Lines: 4194
Relevant Lines: 4416

💛 - Coveralls

@ryansolid
Copy link
Member

I'm going to link a conversation I had with Jin which lead to the last change in error behavior: https://dev.to/ninjin/comment/206d2

I'm not saying this doesn't uphold this but I want to review it in this context. I was thinking that moving towards lazy computation would mean we wouldn't want to error out everything but just things that depended on the broken stuff.. That being said we aren't there in current Solid so we have to make a decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: evalConditions is not a function or its return value is not iterable
3 participants