Proper arm64 testing #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-theriault-swi
force-pushed
the
arm-action
branch
from
2a1bfd1
to
5bdf1ac
Compare
Comment on lines
+148
to
+149
| # install deps and spoof os-release to get gha to work on arm64 alpine | ||
| # https://github.com/actions/runner/issues/801#issuecomment-1374967227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the CI workflows to fully test arm64 support on the same range of targets as x64 (with one minor exception).
The matrix is still loaded from a JSON file using a script, but each entry is also duplicated with a new
archproperty set toarm64andx64. Old alpine releases are currently filtered out from arm64 tests due to a GHA runner issue. The script also creates a new output containing a list of all images tested on arm64.A new job is added before testing to launch the runners and one after to terminate them. Both arm64 and x64 use the same job for testing with
runs-ontaking a different value depending on the architecture. There's an example in the playground repo with essentially the same logic but without all the bindings-specific cruft to get a better idea of how this works.