Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create & Update Token Commands to Stake-Pool CLI #6805

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

sense112
Copy link
Contributor

@sense112 sense112 commented Jun 5, 2024

Adding the following commands to the spl-stake-pool rust cli:

  • create_token_metadata
  • update_token_metadata

All arguments have been catered for with friendly descriptions.

@mergify mergify bot added the community Community contribution label Jun 5, 2024
@sense112 sense112 changed the title Add Stake Pool Token Commands to Stake-Pool CLI Add Create & Update Token Commands to Stake-Pool CLI Jun 5, 2024
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution! There's just two small things to fixup.

Also, in order to pass CI, the code has to be formatted per rustfmt, so could you run ./cargo-nightly fmt --all from the root of the repo and commit the change?

And finally, I don't think this will be an issue, but to be safe, can you also make sure this passes clippy? You can run that from the root of the repo with:

$ ./cargo-nightly clippy -Zunstable-options --all-targets --features test-sbf -- --deny=warnings --deny=clippy::arithmetic_side_effects

Once that's all done, this should be good to merge!

stake-pool/cli/src/main.rs Outdated Show resolved Hide resolved
stake-pool/cli/src/main.rs Outdated Show resolved Hide resolved
sense112 and others added 3 commits June 7, 2024 21:13
Co-authored-by: Jon C <me@jonc.dev>
Co-authored-by: Jon C <me@jonc.dev>
@sense112
Copy link
Contributor Author

sense112 commented Jun 8, 2024

Took me some time to get my environment setup correctly to run these commands.

Thanks for the comments! I have run the format command and clippy seems happy :)

image

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks for your contribution!

@joncinque joncinque merged commit 1afac08 into solana-labs:master Jun 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants