-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
token 2022: add GroupMemberPointer
extension
#5628
token 2022: add GroupMemberPointer
extension
#5628
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
c28bc25
to
e52e102
Compare
6a54e00
to
818d2b5
Compare
bf04d1b
to
65ac100
Compare
65ac100
to
3cf8ea8
Compare
e52e102
to
5f3942d
Compare
65c5fbd
to
6320eb8
Compare
bbd4c02
to
c9ec232
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @joncinque this should be ready for another look. Thanks for the previous review! RIP to repeating extensions 🪦
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few repeated comments, mostly on the interface and structs. Once we agree there, I'll take a closer look at the implementation and test
token/program-2022/src/extension/group_member_pointer/instruction.rs
Outdated
Show resolved
Hide resolved
token/program-2022/src/extension/group_member_pointer/instruction.rs
Outdated
Show resolved
Hide resolved
token/program-2022/src/extension/group_member_pointer/processor.rs
Outdated
Show resolved
Hide resolved
@joncinque considering the discussion here I'm going to re-work this PR and remove the group auth stuff. |
Done. Note I deleted the prior branch in the stack, so I re-wrote the commit here. |
24cb26a
to
d674818
Compare
cb4de48
to
106a697
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base logic looks good! Just one point on the code, and then a few places to simplify the tests
106a697
to
fbcb302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds the
GroupMemberPointer
extension to Token2022.This extension behaves exactly like the existing
GroupPointer
extension, serving to denote the corresponding account containing a mint's group member configurations and prevent any unauthorized configurations.