stake-pool: Allow removal of force-destaked validator #5439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will review this next! |
2501babe
reviewed
Oct 11, 2023
2501babe
previously approved these changes
Oct 11, 2023
|
i love how simple this change is! it handles the case its meant to without needing to check for it, just two independent deactivations that accomplish the broader goal of removing the validator. very nice! |
mergify
bot
dismissed
2501babe’s stale review
Pull request has been modified.
|
That was the hope! I go cross-eyed making these changes sometimes, so I'm glad that you liked the simplicity of this one |
|
@joncinque , seems like |
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As mentioned in a Discord discussion https://discord.com/channels/428295358100013066/859540542608900127/1157393252119478332, stake pools cannot properly handle a validator that has been force-destaked through the new
DeactivateDelinquentinstruction on the stake program.Solution
It's pretty simple -- don't try to deactivate a stake account again during removal. This way, the manager simply needs to remove the validator and then re-run an update to reabsorb the account.
While going through this, I also relaxed the check on an activating / active transient stake account, so that it'll just deactivate it. This way, we prevent a potential malfunction during this edge case: