stake-pool: Remove unsafe pointer casts via Pod types
#5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Got a green light from auditors, moving forward with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#5179 was a quick fix to properly deserialize the stake pool types in-place, updating all contained types to align to 1. This works, but any other type aligned to an address greater than 1 can still expose undefined behavior.
Solution
Rather than parametrizing everything in
BigVecto thePacktrait, changeBigVecto use the bytemuckPodtrait, which is designed for this exact situation.While going through this, I noticed that the custom iterator over
BigVecwas not very performant, and that it was much better to just deserialize the whole slice in-place. With this PR, we can once again support the big pool size from #5179.