Refactor unpack and make test more robust #3417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Aug 3, 2022
mvines
previously approved these changes
Aug 3, 2022
|
Will bump spl-token to v3.3.1 before merging this |
joncinque
added a commit
to joncinque/solana-program-library
that referenced
this pull request
Aug 3, 2022
This reverts commit c618de3.
CriesofCarrots
added a commit
to CriesofCarrots/solana-program-library
that referenced
this pull request
Aug 3, 2022
* Refactor hasty fix to match token-2022 * Make test exhaustive * cargo fmt Co-authored-by: Michael Vines <mvines@gmail.com>
CriesofCarrots
added a commit
that referenced
this pull request
Aug 4, 2022
* check that unpack is tolerant of small sizes (#3416) * Refactor unpack and make test more robust (#3417) * Refactor hasty fix to match token-2022 * Make test exhaustive * cargo fmt Co-authored-by: Michael Vines <mvines@gmail.com> * Readd proptests without losing unit test, #3421 Co-authored-by: anatoly yakovenko <anatoly@solana.com> Co-authored-by: Michael Vines <mvines@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3416 added some guard rails, but we already have an elegant way of doing this in token-2022.
This PR refactors those checks to match, and makes the unpack unit test exhaustive.