stake-pool: Handle force destaked accounts #3152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During a cluster restart, it's possible for stake accounts to get force destaked. If a stake pool contains a force destaked validator stake account, many parts will stop working.
Solution
Provide two safeguards:
Initialized
, assume that a destake happened, merge it into the reserve, and effectively remove that validator from the pool. It can always be re-added again if needed.Initialized
, something bad happened, so prevent the increase. This is in the case of a cronjob that isn't aware that a force destake happened, and tries to increase stake on the validator.