Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jon C <me@jonc.dev>
  • Loading branch information
samkim-crypto and joncinque committed Jul 15, 2024
1 parent ac19d52 commit ee046e3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion token/confidential-transfer/proof-extraction/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pub enum TokenProofExtractionError {
PedersenCommitmentMismatch,
#[error("Range proof length mismatch")]
RangeProofLengthMismatch,
#[error("Fee pparameters mismatch")]
#[error("Fee parameters mismatch")]
FeeParametersMismatch,
#[error("Curve arithmetic failed")]
CurveArithmetic,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ fn calculate_fee(transfer_amount: u64, fee_rate_basis_points: u16) -> Option<(u6

// Warning: Division may involve CPU opcodes that have variable execution times.
// This non-constant-time execution of the fee calculation can theoretically
// reveal information about the transfer amount. For transfers that invole
// reveal information about the transfer amount. For transfers that involve
// extremely sensitive data, additional care should be put into how the fees
// are calculated.
let fee = numerator
Expand Down

0 comments on commit ee046e3

Please sign in to comment.