fix: switch to vertx server backend #223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There issue with non-deterministic EOF is observable by others but so far there is no good explanation (or test method) given (see [1]) therefore for the time being we are switching to vertx http server. TODO: * `OPTIONS` request is not accepted and results in `405 Method Not Allowed` therefore UI is not able to talk to the server but calling `curl` works * at the moment one cannot customise the logs hence they are not displayed when the server is started Verifies #49 [1] http4s/blaze#668
Comment on lines
+18
to
32
| Dispatcher[IO] | ||
| .use { dispatcher => | ||
| { | ||
| Dependencies | ||
| .wire(config) | ||
| .use { case Dependencies(httpApi) => | ||
| /* | ||
| allocates the http api resource, and never releases it (so that the http server is available | ||
| as long as our application runs) | ||
| */ | ||
| httpApi.resource(dispatcher).useForever | ||
| } | ||
| } | ||
| } | ||
| .unsafeRunSync() |
There was a problem hiding this comment.
Current approach is based on Vert.x example
Alternatively for comprehension can be used but it is hard to tell if it is more readable ;)
(for {
dispatcher <- Dispatcher[IO]
servers <- Dependencies
.wire(config)
.map { case Dependencies(httpApi) =>
/*
allocates the http api resource, and never releases it (so that the http server is available
as long as our application runs)
*/
httpApi.resource(dispatcher).useForever.unsafeRunSync()
}
} yield (dispatcher, servers)).useForever.unsafeRunSync()
@adamw WDYT?
There was a problem hiding this comment.
I think we can make it more readable :)
for {
dispatcher <- Dispatcher[IO]
httpApi <- Dependencies.wire(config)
servers <- httpApi.resource(dispatcher)
_ <- Resource.never
} yield whatever
adamw
reviewed
Oct 17, 2022
| .prependInterceptor(CorrelationIdInterceptor) | ||
| // all errors are formatted as json, and there are no other additional http4s routes | ||
| .defaultHandlers(msg => ValuedEndpointOutput(http.jsonErrorOutOutput, Error_OUT(msg)), notFoundWhenRejected = true) | ||
| // TODO customise the serverLog when available |
adamw
reviewed
Oct 17, 2022
| def resource(dispatcher: Dispatcher[IO], endpoints: List[ServerEndpoint[Any with Fs2Streams[IO], IO]], port: Int) = { | ||
| Resource.make( | ||
| IO.delay { | ||
| val vertx = Vertx.vertx() |
There was a problem hiding this comment.
I think we should crate a single shared Vertx
|
We should check the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There issue with non-deterministic EOF is observable by others but so far there is no good explanation (or test method) given (see #668) therefore for the time being we are switching to vertx http server.
TODO:
OPTIONSrequest405 Method Not Allowedtherefore UI is not able to talk to the server but callingcurlVerifies #49