Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/example yolov5 #50

Merged
merged 42 commits into from
Jan 27, 2023
Merged

Feat/example yolov5 #50

merged 42 commits into from
Jan 27, 2023

Conversation

kamilrzechowski
Copy link
Collaborator

@kamilrzechowski kamilrzechowski commented Jan 17, 2023 •
edited
Loading

Description

The PR introduces example library usage for YOLO_v5.

It works for a different types of explainers.

How Has This Been Tested?

This is an example script. Thus no strict tests were written for the script. The successful run was counted as the script test.

  • successful run

Checklist:

  • I have updated all related pyproject.toml files.
  • I have updated lock files.
  • I have set an Assignee and Reviewers.
  • I have labeled the PR correctly.
  • I have performed a self-review of my own code.
  • I have covered my code and changes with unit tests.
  • I have annotated types as extensively as possible.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • All code references and dependencies will work.

@kamilrzechowski kamilrzechowski self-assigned this Jan 17, 2023
@kamilrzechowski kamilrzechowski marked this pull request as ready for review January 18, 2023 11:32
@kamilrzechowski kamilrzechowski added the enhancement New feature or request label Jan 18, 2023
adamwawrzynski
adamwawrzynski approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@adamwawrzynski adamwawrzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
kamilrzechowski and others added 5 commits January 25, 2023 08:39
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
f39927d 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
9f3a86c 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
3b88158 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
c840acc 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
379763e 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
rpytel1
rpytel1 reviewed Jan 25, 2023
View reviewed changes
example/notebooks/basic_usage.ipynb Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.py Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.py Show resolved Hide resolved
adamwawrzynski
adamwawrzynski approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@adamwawrzynski adamwawrzynski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly typos, requests for more verbose comments ,etc.

example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_utils.py Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.ipynb Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.py Outdated Show resolved Hide resolved
example/yolov5_exmaple/yolo_xai.py Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
kamilrzechowski and others added 16 commits January 26, 2023 09:12
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_utils.py
09774a2 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_utils.py
fb55ea0 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_utils.py
b9565c8 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.py
21b9d21 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
0a7f2c9 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
6d21b87 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
7fbd40d 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
9ca4bfb 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
a2f77e4 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
7c78982 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
65b43bf 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
d7bbe87 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski @adamwawrzynski
Update example/yolov5_exmaple/yolo_xai.ipynb
466201b 
Co-authored-by: adamwawrzynski <adamwawrzynski@wp.pl>
@kamilrzechowski
commented unused lines of code removed. pyproject.toml torch dependen…
31aec8e 
…cies version problem fixed
@kamilrzechowski
ipynb same as yolo_xai.py
cdb93ee
@kamilrzechowski
mypy error with torch.device fixed. Thank you Adam W.
57d46ae
@kamilrzechowski kamilrzechowski merged commit e13530f into main Jan 27, 2023
@kamilrzechowski kamilrzechowski deleted the feat/example_yolov5 branch January 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwawrzynski adamwawrzynski adamwawrzynski approved these changes

@rpytel1 rpytel1 rpytel1 approved these changes

@adamjankaczmarek adamjankaczmarek Awaiting requested review from adamjankaczmarek

Assignees

@kamilrzechowski kamilrzechowski

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamilrzechowski @rpytel1 @adamwawrzynski