Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created quantum phase estimation program for examples dir #91

Merged
merged 2 commits into from
Dec 15, 2020
Merged

created quantum phase estimation program for examples dir #91

merged 2 commits into from
Dec 15, 2020

Conversation

ryanhill1
Copy link
Contributor

No description provided.

@vsoftco
Copy link
Member

vsoftco commented Dec 14, 2020

Nice, thanks! The line std::cout << ">> Measurement result q0: " << res << '\n'; should be "...q" << i<<": ", right?

@ryanhill1
Copy link
Contributor Author

Nice, thanks! The line std::cout << ">> Measurement result q0: " << res << '\n'; should be "...q" << i<<": ", right?

Yes, it should. Good catch

@vsoftco vsoftco merged commit a2057eb into softwareQinc:main Dec 15, 2020
@ryanhill1
Copy link
Contributor Author

It seems that this last commit failed the random.cpp unit test for qpp_rand.RealMatrix line 148: EXPECT_NEAR(0, average, 1); // very likely. The message reads, The difference between 0 and average is 1.0221263420644076, which exceeds 1. Do you know what caused this failure?

@vsoftco
Copy link
Member

vsoftco commented Dec 15, 2020

@ryanhill1 That's expected sometimes. It's a randomness test, which sometime can fail (for example, if the deviation happens to be a bit too large). I restarted that particular build, so it should pass (almost always passes second time :) ). I should modify that test to use more sophisticated randomness checks when I get some time...

@ryanhill1
Copy link
Contributor Author

Got it. Thanks, love the program!

@vsoftco
Copy link
Member

vsoftco commented Dec 15, 2020

Great thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants