fix: webview in stack #607
Conversation
Co-authored-by: Krisztiaan <krisz011@gmail.com>
|
Hah, idk how it goes in this repo, but lgtm! :) |
|
looks good |
|
@WoLewicki can we merge this? |
|
We will see after some discussion if there are no better options. For now, you can use patch-package and apply those changes in order to test if everything works right. |
| @@ -151,7 +152,22 @@ public void setTransitioning(boolean transitioning) { | |||
| return; | |||
| } | |||
| mTransitioning = transitioning; | |||
| super.setLayerType(transitioning ? View.LAYER_TYPE_HARDWARE : View.LAYER_TYPE_NONE, null); | |||
| boolean isWebViewInScreen = hasWebView(this); | |||
| super.setLayerType(transitioning && !isWebViewInScreen ? View.LAYER_TYPE_HARDWARE : View.LAYER_TYPE_NONE, null); | |||
There was a problem hiding this comment.
This line isn't consistent with the PR description. You say that we don't change the layer type in case there is a webview, but it appears that we change it to NONE. Should we avoid updating layer type altogether as stated in the description?
There was a problem hiding this comment.
We could not change the layer type, but if it is already HARDWARE for some reason, it will probably lead to crash. I can add a check for if the layer is not HARDWARE and, if so, just do nothing when there is a WebView.
|
can we merge this? |
Added check for if there is WebView on the screen we are transitioning to. If there is, we don't change the layer type in stack navigator to avoid crash seen in #105.