Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Android): fix lint warning of CustomToolbar component #2176

Merged
merged 3 commits into from
Jun 17, 2024
Merged

chore(Android): fix lint warning of CustomToolbar component #2176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28e884d
Fix lint warning
kkafar Jun 8, 2024
33460e8
Merge branch 'main' into @kkafar/missing-suppress
kkafar Jun 17, 2024
2fe1e99
Suppress lints in more views
kkafar Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/CustomSearchView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package com.swmansion.rnscreens

import android.annotation.SuppressLint
import android.content.Context
import androidx.activity.OnBackPressedCallback
import androidx.appcompat.widget.SearchView
import androidx.fragment.app.Fragment

@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated.
class CustomSearchView(context: Context, fragment: Fragment) : SearchView(context) {
/*
CustomSearchView uses some variables from SearchView. They are listed below with links to documentation
Expand Down
2 changes: 2 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/CustomToolbar.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
package com.swmansion.rnscreens

import android.annotation.SuppressLint
import android.content.Context
import androidx.appcompat.widget.Toolbar

// This class is used to store config closer to search bar
@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated.
open class CustomToolbar(context: Context, val config: ScreenStackHeaderConfig) : Toolbar(context)
2 changes: 1 addition & 1 deletion android/src/main/java/com/swmansion/rnscreens/Screen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import com.facebook.react.uimanager.UIManagerHelper
import com.facebook.react.uimanager.UIManagerModule
import com.swmansion.rnscreens.events.HeaderHeightChangeEvent

@SuppressLint("ViewConstructor")
@SuppressLint("ViewConstructor") // Only we construct this view, it is never inflated.
class Screen(context: ReactContext?) : FabricEnabledViewGroup(context) {
val fragment: Fragment?
get() = fragmentWrapper?.fragment
Expand Down