fix: change -[RNSScreenContainer init] to call -[UIView initWithFrame:] designated initalizer

[Brett-Best]

Description

Ensures RNSScreenContainer UIView subclass calls a designated initializer, this fixes an issue where subclassing RNSScreenContainer would recursively loop through the inits - ending in a crash.

UIView.h has:
- (instancetype)initWithFrame:(CGRect)frame NS_DESIGNATED_INITIALIZER;

Checklist

• Included code example that can be used to test this change
• Updated TS types
• Updated documentation:
  • https://github.com/software-mansion/react-native-screens/blob/main/guides/GUIDE_FOR_LIBRARY_AUTHORS.md
  • https://github.com/software-mansion/react-native-screens/blob/main/native-stack/README.md
  • https://github.com/software-mansion/react-native-screens/blob/main/src/types.tsx
  • https://github.com/software-mansion/react-native-screens/blob/main/src/native-stack/types.tsx
• Ensured that CI passes

[kkafar]

Hey @Brett-Best, while indeed we do not call designated initializer on our parent class (thus this change makes sense) but I do not see a scenario of how this would lead to a crash? Could you elaborate a bit?

[Brett-Best]

We have a subclass of RNSScreenContainerView which has a custom init (#4-#3) that takes some dependencies.
We call super.init() in #3, this then goes to #2 which then due to the current super call ends up back in NativeAppView [not the superclass of RNSScreenContainerView] #1 and then attempts to call the unimplemented init(frame: in our subclass.

Changing to the designated initialiser makes #2 go to UIView rather than NativeAppView, fixing the problem.

#0 in NativeAppView.init(frame:) ()
#1 in @objc NativeAppView.init(frame:) ()
#2 in -[RNSScreenContainerView init] at /node_modules/react-native-screens/ios/RNSScreenContainer.mm:63
#3 in NativeAppView.init(analyticsInteractor:bundleProvider:deepLinkRouter:routeConfigService:router:screenDimensionsManager:socialProfileInteractor:) at mobile/Bridge/NativeComponents/NativeAppView.swift:75
#4 in NativeAppView.__allocating_init(analyticsInteractor:bundleProvider:deepLinkRouter:routeConfigService:router:screenDimensionsManager:socialProfileInteractor:) ()
#5 in closure #1 in NativeAppViewManager.view() at mobile/Bridge/NativeComponents/NativeAppViewManager.swift:49
#6 in partial apply for closure #1 in NativeAppViewManager.view() ()
#7 in static MainActor.assumeIsolated<τ_0_0>(_:file:line:) ()
#8 in static MainActor.assumeIsolated<τ_0_0>(_:file:line:) ()
#9 in NativeAppViewManager.view() at mobile/Bridge/NativeComponents/NativeAppViewManager.swift:48
#10 in @objc NativeAppViewManager.view() ()
#11 in -[RCTComponentData createViewWithTag:rootTag:] at /node_modules/react-native/React/Views/RCTComponentData.m:82
#12 in __50-[RCTUIManager createView:viewName:rootTag:props:]_block_invoke at /node_modules/react-native/React/Modules/RCTUIManager.m:1007

[Brett-Best]

@kkafar any chance this could also get included in the release this week if all goes well?

[kkafar]

Yeah yeah, I think we're fine here now. Thanks for these details!