Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Importing of project into Swift projects #2160

Conversation

Brett-Best
Copy link
Contributor

Description

Fixes #2158 by making C++ headers project instead of public.
Original code sample (in the issue) can be updated to include this change verifying the fix.

Checklist

@kkafar
Copy link
Member

kkafar commented May 28, 2024

Hi @Brett-Best, thanks for taking your time to introduce these changes 🎉 We will test these changes in reanimated context, because they are main consumers of this API and if it goes smoothly we can proceed with merging. FYI next release should be coming next week (in positive scenario).

@Brett-Best
Copy link
Contributor Author

Thanks, it might be worth including import RNScreens in an example project or something that can be ran on CI to prevent breaking importing the library in the future.

@kkafar kkafar changed the title Fix: Importing of project into Swift projects fix: Importing of project into Swift projects Jun 4, 2024
Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we're fine on front of reanimated interop & also seems that it works well in runtime. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing RNScreens in Xcode iOS Swift file fails to compile
2 participants