chore: Implement missing codegen interfaces #2153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
reviewed
May 22, 2024
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt
Outdated
Show resolved
Hide resolved
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt
Outdated
Show resolved
Hide resolved
maciekstosio
force-pushed
the
@maciekstosio/Implement-missing-codegen-interfaces-
branch
from
3472960
to
5242a79
Compare
|
I've sent some notes on private message 😅 |
maciekstosio
force-pushed
the
@maciekstosio/Unify-example-app
branch
from
663bafd
to
92357ae
Compare
maciekstosio
changed the base branch from
@maciekstosio/Unify-example-app
to
main
… github.com:software-mansion/react-native-screens into @maciekstosio/Implement-missing-codegen-interfaces-
|
Closing in favor of #2163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when we change native props autogenerated by codegen we need to manually update changed files. We're going to automate so everything is copied automatically, but as a first step we need to implement those that aren't yet. This is what this PR introduces.
Test code and steps to reproduce
Go through Example app, nothing should change.