Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent iOS host object installation from getting the wrong bridge #2146

Merged
merged 1 commit into from
May 21, 2024
Merged

Prevent iOS host object installation from getting the wrong bridge #2146

merged 1 commit into from
May 21, 2024

Conversation

gabrieldonadel
Copy link
Contributor

Description

Similar to software-mansion/react-native-reanimated#5953, using [RCTBridge currentBridge] may lead to the wrong bridge in apps that have multiple React instances, as is the case for expo-dev-client. This results in apps sometimes crashing when reloading the bundle after interacting with the DevMenu.

image

Changes

Instead of using [RCTBridge currentBridge] we can just call self.bridge and ensure the correct bridge is always used

@kkafar kkafar requested review from WoLewicki and kkafar May 20, 2024 11:29
@kkafar
Copy link
Member

kkafar commented May 20, 2024

Hey @gabrieldonadel, thanks for noticing this and taking your time to fix this.
I'll be asking @WoLewicki to take a look at these changes as he is well-versed with bridgeless mode.

WoLewicki
WoLewicki approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I made a PR changing it some time ago: #2120 but it is stuck with some problems in core. I think we can merge that one to fix at least one of the issues already 🚀

@WoLewicki WoLewicki merged commit 4f6f974 into software-mansion:main May 21, 2024
5 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/fix-installing-host-object branch May 21, 2024 09:21
@toomeem toomeem mentioned this pull request Jul 10, 2024
Merged
@2lambda123 2lambda123 mentioned this pull request Jul 11, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
Open
Open
Open
@asraful-cse asraful-cse mentioned this pull request Jul 21, 2024
Open
@ImNotVarun ImNotVarun mentioned this pull request Jul 22, 2024
Open
This was referenced Jul 22, 2024
Open
Open
Open
This was referenced Jul 24, 2024
Open
Open
This was referenced Jul 25, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@prathik2401 prathik2401 mentioned this pull request Aug 1, 2024
Merged
This was referenced Aug 3, 2024
Open
Open
This was referenced Aug 20, 2024
Open
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@2lambda123 2lambda123 mentioned this pull request Aug 22, 2024
Merged
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
Open
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WoLewicki WoLewicki WoLewicki approved these changes

@kkafar kkafar Awaiting requested review from kkafar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieldonadel @kkafar @WoLewicki