-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: unify tests in test apps #2135
Conversation
f12dcc6
to
abcc595
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job overall. Left important remark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and there is one more thing. There could be some test cases that were present only in FabricTestExample
and not in TestsExample
or the other way around. Please make sure, that we do not remove them entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks nice now 🎉
At last we need better name for the tests
directory, as this is usually used in context of unit/integration tests and gives wrong clues about its contents. What do you think of test-screens
or something similar?
27d56fc
to
397e30f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go 🟢
If you tested & everything is working I think we can proceed.
Description
This PR intents to unify tests used by test apps
Changes
Test code and steps to reproduce
Checklist