fix(iOS): Fix updating bounds while changing interface orientation

[tboba]

Description

Currently while trying to change the interface orientation there's a bug that doesn't layout the next screen, causing the old frame to remain (which means that the next screen will be rotated regarding to the previous orientation.
This PR fixes that problem by calling [_controller.view setNeedsLayout] on the navigationController, where the view is being rotated.

When I was testing this PR I also came to another solution of setting the frame in viewWillTransitionToSize but I didn't spot any differences between one solution and this one.

- (void)viewWillTransitionToSize:(CGSize)size
       withTransitionCoordinator:(id<UIViewControllerTransitionCoordinator>)coordinator
{
  [super viewWillTransitionToSize:size withTransitionCoordinator:coordinator];
#ifdef RCT_NEW_ARCH_ENABLED
  [coordinator
      animateAlongsideTransition:^(id<UIViewControllerTransitionCoordinatorContext> coordinator) {
        self.screenView.frame = CGRectMake(0, 0, size.width, size.height);
      }
      completion:^(id<UIViewControllerTransitionCoordinatorContext> coordinator) {
        [self.screenView setNeedsLayout];
      }];
#endif
}

I've also tried to make a workaround of a reaaaally old bug in React Native: facebook/react-native#16060, but unfortunately I failed with that 😕

Closes #1738.

Changes

• Adds call to setNeedsLayout during the interface orientation

Screenshots / GIFs

Before

Screen.Recording.2023-11-15.at.14.36.19.mov

After

Screen.Recording.2023-11-15.at.14.33.58.mov

Test code and steps to reproduce

You can find in this PR Test1970.tsx that contains test test I've tested while making this change.

Checklist

• Included code example that can be used to test this change
• Ensured that CI passes

[kkafar]

As we discussed: the iOS change is ok, but we still need to work on the view clipping (or at least determine why the view is clipped) & I would suggest that we remove Test1970 & reuse some other test example with orientation change (if there is one).

[kkafar]

One more note

[dani-mp]

Are you folks planning on getting this merged? There are a bunch of related issues reported in different repositories about this: expo/expo#27228 (comment).

[Will94o]

Hello ! thanks for the fix but when will it be merged ?

[dani-mp]

In case folks are having problems with this too, I could have a non-buggy and consistent behavior using stacks with different orientations (some landscape, some portrait) using React Navigation's orientation screen prop. I'm developing a game and some stacks must be always in landscape, and the rest (login, onboarding, settings, and so on) are always portrait. When I tried implementing this with expo-screen-orientation, it was buggy.

[tboba]

Hi @dani-mp! Could you suggest such patch for changing the orientation? I wonder if we could avoid calling setNeedsLayout on iOS.

[kkafar]

I think we can process with this PR

[kkafar]

One single note, let's leave a comment above this line why do we trigger layout here (e.g. link to this PR).

[kkafar]

Yeah, thanks for that comment.
I think we are good to go.

[sanghavip16]

@tboba can you please release new React Native npm package of "react-native-screens" with above changes?

[kkafar]

We're in release process currently, however still waiting for few PRs to land on main. I won't promise anything, cause last date I promised was that it will be ready for week ago, however it should be soon