fix: delay ScreenContainer updates in same manner as ScreenStack #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLewicki
changed the title
kacperkapusciak
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added delayed update logic to
ScreenContainerin order to resolve issues with too early detached nested navigators when going back from a screen innative-stackwith nested different navigators. This change was part of synchronous fragment updates introduced in #1066. Going back like that triggersremoveAllScreenscode of the nested navigator and it resolved in detaching all of the child screens before the update ofnative-stackwas dispatched, leading to blank screen from the start of navigation.Test code and steps to reproduce
Test860.tsxto see that without this change the nested navigators are detached at the start of transition.Checklist