Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare repo for Apple Silicon #1094

Merged
merged 5 commits into from
Sep 7, 2021

Conversation

kacperkapusciak
Copy link
Member

Description

This PR makes sure that example project used to test react-native-screens compile on Apple arm64 chips.

Added a few config lines to Podfile needed to compile iOS code. Thanks to facebook/react-native#31941.
Android doesn't need any changes due to recent gradle bump to 6.9 in #1042

Test code and steps to reproduce

cd TestsExample/
yarn # install packages
cd ios && pod install && cd .. # install pods
yarn start # start metro
# in separate terminal
npx react-native run-android # build Android
npx react-native run-ios # build iOS

Same for Example/ ⬆️

Projects should compile on both arm and intel-based processors

Checklist

  • Ensured that CI passes

Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It build on my intel mbp, so I think we can merge it 🎉

@mikehardy
Copy link
Contributor

Just a note since I'm trying to drive the needed iOS changes all over, and into the main repo - it looks like 0.66 won't need the workaround: react-native-community/releases#246 (comment) - so I'm not sure on timing for screens releases or whether you want to make sure you work on react-native 0.65 or not, but at minimum you might add a note to remove this for 0.66 since it'll be upstreamed.

And thanks for screens by the way, it's in all my projects

@kacperkapusciak
Copy link
Member Author

@mikehardy thank you!
I've added a note in 2733adf

@kacperkapusciak kacperkapusciak merged commit afd0b56 into master Sep 7, 2021
@kacperkapusciak kacperkapusciak deleted the @kacperkapusciak/use-apple-silicon branch September 7, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants