async -> sync #1006
Closed
async -> sync #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
reviewed
Jul 12, 2021
| if (mCurrentTransaction == null) { | ||
| mCurrentTransaction = mFragmentManager.beginTransaction(); | ||
| mCurrentTransaction.setReorderingAllowed(true); | ||
| if (mCurrentTransaction != null) { |
There was a problem hiding this comment.
this seems to no longer be necessary if we create new transaction and then commit it with each single operation. As a consequence we wouldn't need the mCurrentTransaction field nor need to call getOrCreaeTransaction nor tryCommitTransaction
There was a problem hiding this comment.
I think it was left for usage with ScreenStack, where we have animations in Fragments, so we want to concatenate all the operations into one and run animations on them. Btw, I would change the name commitNowAllowingStateLoss to something like commitTransaction.
2 tasks
|
Closed in favor of #1066. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Test code and steps to reproduce
Checklist