-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native Stack, React-nativation 5, white screen when navigating back #556
Comments
I cannot repro this. Can you provide a repo where this happens? |
@WoLewicki here is the repo. I made it for Reanimated but I noticed this one as well, so don't mind the name. |
I face same issue on |
Yes, I have managed to reproduce it. |
@beqramo did you manage to make this bug appear every time, not randomly? It would be very helpful for debugging. |
@WoLewicki I have no clue when it happens sorry |
@WoLewicki It happens sometimes on navigating back for the second time, sometimes takes longer, as if you notice the screen recording it happened after 20 seconds or so. |
#556 (comment) |
Can you try and change https://github.com/software-mansion/react-native-screens/blob/master/android/src/main/java/com/swmansion/rnscreens/ScreenContainer.java#L189 to |
I changed the following line from node_modules and rebuilt the project as the result the bug seemed to be disappeared ( I couldn't face the white screen on navigating multiple times for 20 seconds or so ). plus the transition had changed a bit as well. here is the screen recording. Should I test in release build as well? @WoLewicki |
I would be grateful if you could. |
It happens for me as well with React Navigation 5 and screens enabled. |
@chismadalina does it happen after applying this: #556 (comment)? And are there any other issues after doing so? |
@WoLewicki it does fix the issue when navigation back but then I have a white flicker when I enter the screen, only on some screens. |
Can you provide minimal code that shows the flickering after that change? |
@WoLewicki I don't think the code of the screen will help as it happens in different screens |
@chrisnojima does it happen only on the first screen? |
#556 (comment) fixed a similar bug for me that was showing only in release builds. navigating from A -> push B -> goBack to A -> push B would sometimes cause B to show with opacity < 1. |
One of our testers reported a re-occurrence of this bug after the fix mentioned above. At least, the issue appears to be less common |
One more note from me and sorry for the noise. It looks like my issue wasn't related to react-native-screens at all, but rather LayoutAnimation on android |
Can someone let me know what worked for them? |
@ahmed5605 you can try and change the line to |
in fact, in my case, it crashes with fatal exception about react-native-screens, but looks like a freeze with white background, exactly as described |
@gazedash can you provide a reproduction of this? It would help with debugging. |
Still seeing repros of this issue. The line switch above didn't fix the issue for me - has anyone found a fix? |
The flickering is still happening with the components like fast-image and svg when we call fast-image.mov |
|
@darron1217 I think your problem is described in #773. |
@WoLewicki Sorry, it was map plugin's problem. |
@WoLewicki Do you happen to know if the issue with crashing/white screens when going back is being tracked? |
Unfortunately we didn't come up with a better solution than proposed yet, but we are open to suggestions. |
Fix occasional white screen on goBack. Solution from @WoLewicki software-mansion#556 (comment)
This seems to have fixed the white screen issue on goBack but the navigation animation is different now. It's more like a partial swoop in from the left. |
Hopefully this issue should be solved by #1066 since the fragment transactions would be committed synchronously then. Could you check if it does not introduce any new problems? It certainly needs much testing and we would like to add it to the next release. |
When navigating forward and back using back button in the header, sometimes ( like after 3, 4 ) times of navigating the first screen becomes white ( as it appears ).
Happens on Android not tested on IOS
how to reproduce
create a native stack navigator using react navigation and move forward and back by pressing the back button in the header.
The text was updated successfully, but these errors were encountered: