-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 is laggy on Android #1017
Comments
After digging into the code changes between I think |
What exactly do you mean by a lag issue? The blinking at the start of transition? If so, it is already documented in #111 and there are solutions provided for this behavior, e.g. #111 (comment). Is there anything more we can help you with concerning this? |
@WoLewicki Well, blinking is one of the issues. But my problem is mainly the frame drop during the screens transition, it's very obvious since I'm using All the solutions I found in the #111 that you mentioned only solve the blinking issue, but the frame drop issue will only get solved if I call |
Ok so we would need more information to look into this issue.
|
So while I creating this repo, I do notice that it only happened if I have a demo.mp4 |
Thanks for all the information! Could you also post the video of how it behaves without |
Here's the video without demo_2.mp4 |
same here |
One issue I can think of might be searching through all of the children at the beginning of transition due to bug with |
Tried that, and still the same. |
Issue validatorThe issue is invalid!
|
After some digging I think I found the issue. The laggy animation was caused by asynchronous attaching and detaching fragments. |
Description
I'm using React Navigation as my app navigation library, which at the time when I installed
react-native-screens
it was v2. So I decided to upgrade to the v3 to test it out and notices that there is a huge lag when navigating between screens, especially for those screens that contain huge listings. I decided to test out all the versions from2.3.0
to3.4.0
, and the lag issue only happens on3.0.0
& above.One of the interesting parts I found out is that, during the process of testing, after I build & install the app (with v3) on Android, I decided to downgrade to v2 to prove my findings, and I forgot to stop my metro packager before I do a
yarn install
, surprisingly the lag issue fixed for some reason. This means the android native-side is using v3, while the JS-side of thereact-native-screens
is using v2, so I'm thinking maybe there is some implementation on the JS codebase inreact-native-screens
causing the lag issue.Screenshots
Steps To Reproduce
Expected behavior
Actual behavior
Snack or minimal code example
Package versions
The text was updated successfully, but these errors were encountered: