Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve formatting of snapnshot mismatch comparison #6272

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Improve formatting of snapnshot mismatch comparison #6272

merged 3 commits into from
Jul 17, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Jul 16, 2024 •
edited

Summary

The new snapshots:

  • group columns in pairs
  • only highlight the values that doesn't match

image

image

image

Test plan

@Latropos Latropos requested a review from piaskowyk July 16, 2024 09:07
@Latropos Latropos marked this pull request as ready for review July 16, 2024 09:22
@Latropos Latropos added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 12db071 Jul 17, 2024
5 checks passed
@Latropos Latropos deleted the acynk/string-format branch July 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Latropos @piaskowyk