Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: makeMutable documentation and examples #6261

Merged
merged 19 commits into from
Jul 31, 2024

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Jul 11, 2024

Summary

This PR adds makeMutable function documentation with the usage example.

@MatiPl01 MatiPl01 self-assigned this Jul 11, 2024
@MatiPl01 MatiPl01 changed the title makeMutable documentation and examples docs: makeMutable documentation and examples Jul 15, 2024
@MatiPl01 MatiPl01 marked this pull request as ready for review July 15, 2024 10:53
packages/docs-reanimated/docs/core/makeMutable.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/core/makeMutable.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/core/makeMutable.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/core/makeMutable.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/docs/core/makeMutable.mdx Outdated Show resolved Hide resolved
packages/docs-reanimated/src/examples/MakeMutable.tsx Outdated Show resolved Hide resolved
MatiPl01 and others added 2 commits July 22, 2024 14:45
Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
@MatiPl01 MatiPl01 requested a review from piaskowyk July 22, 2024 12:59
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a well documented bad API is better than bad API with no documentation so I guess it's better that way ✅

amazing work on this! 🥇

@MatiPl01 MatiPl01 enabled auto-merge July 31, 2024 12:40
@MatiPl01 MatiPl01 added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit da2e2ef Jul 31, 2024
6 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/add-makeMutable-docs branch July 31, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants