-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workletizable Context Objects #6229
Merged
tjzel
merged 11 commits into
@tjzel/plugin/allow-file-workletization
from
@tjzel/plugin/context-objects
Jul 17, 2024
Merged
Workletizable Context Objects #6229
tjzel
merged 11 commits into
@tjzel/plugin/allow-file-workletization
from
@tjzel/plugin/context-objects
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
133377c
to
13bfdf9
Compare
…ugin/context-objects
…ugin/context-objects
4dcf605
into
@tjzel/plugin/allow-file-workletization
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the concept of Context Objects on the Worklet Runtime.
What?
Context Object is a shareable object that doesn't lose its
this
binding when it goes to the Worklet Runtime. To define an object as a Context Object, the user has to define property__workletObject
on it. (Should it be__contextObject
?)Why?
Currently it's not possible to refer to an object's methods from its other methods.
How?
Context Objects are handled as another type of shareable entity on the React Runtime.
__workletObjectFactory
to Context Objects. It's a function that creates an identical object.Test plan