Fix test of animations on Android #6199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
requested changes
Jul 3, 2024
| @@ -158,8 +161,10 @@ describe('Add three delays', () => { | |||
| ); | |||
|
|
|||
| expect([{ width: 0 }, { width: 0 }, ...updatesOneDelay]).toMatchSnapshots(updates); | |||
| expect(updatesOneDelay).toMatchNativeSnapshots(nativeUpdatesOneDelay); | |||
| expect(updates).toMatchNativeSnapshots(nativeUpdates); | |||
| if (componentType !== 'INLINE' || Platform.OS !== 'android') { | |||
There was a problem hiding this comment.
There are quite a few workarounds in this PR. I understand that they fix some issues, but let me take some time to consider a potential solution to fix the root cause of the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains changes necessary to make tests of animations pass on Android. I also make function
getAnimatedStylereturn correct type of a prop (previously it was always returning a string)Test plan
Run tests of animations on Paper on both IOS and Android.
The only error is the following one on IOS:
