Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React Native 0.75 #6185

Merged
merged 32 commits into from
Aug 2, 2024
Merged

Support React Native 0.75 #6185

merged 32 commits into from
Aug 2, 2024

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jun 28, 2024

Summary

This PR adds support for React Native 0.75 (currently: 0.75.0-rc.6).

https://swmansion.slack.com/archives/C048Z2NNEBY/p1719603649642539

Test plan

@raghav-reglobe
Copy link

raghav-reglobe commented Jul 10, 2024

Hi, when can we expect this to be merged.

@tomekzaw
Copy link
Member Author

Hi! We still need to check this PR against 0.75.0-rc.4 and do some cleanup. I hope we can get this merged next week.

Rexogamer added a commit to revoltchat/rvmob that referenced this pull request Jul 15, 2024
- replaced RNFI with the built-in Image component. not as good but it's actually maintained + this could reduce app sizes further
- add temporary RNGP patch (see [here](facebook/react-native#45403 (comment)) for more context)
- currently waiting on [reanimated](software-mansion/react-native-reanimated#6185)
@tomekzaw tomekzaw requested a review from piaskowyk July 30, 2024 09:38
@tomekzaw
Copy link
Member Author

TODO: bump example apps dependencies to versions that support RN 0.75

@tomekzaw tomekzaw marked this pull request as ready for review July 31, 2024 14:24
@tomekzaw tomekzaw requested a review from szydlovsky July 31, 2024 14:24
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reactNativeVersionPatch looks scary, but I understand it 💀

Copy link
Contributor

@szydlovsky szydlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some answers first 👁️👅👁️

apps/common-app/src/examples/index.ts Outdated Show resolved Hide resolved
apps/common-app/src/examples/index.ts Outdated Show resolved Hide resolved
@tomekzaw
Copy link
Member Author

TODO: investigate weird home screen layout on Fabric iOS
Screenshot 2024-07-31 at 18 06 34

@raghav-reglobe
Copy link

raghav-reglobe commented Aug 2, 2024

Hi @tomekzaw, please help us publishing this, as other two libs are already published.

@tomekzaw
Copy link
Member Author

tomekzaw commented Aug 2, 2024

@raghav-reglobe We'll merge this PR and publish 3.15.0 once we fix build error in macOS example.

@tomekzaw tomekzaw added this pull request to the merge queue Aug 2, 2024
Merged via the queue into main with commit 7df5fd5 Aug 2, 2024
18 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/react-native-0.75 branch August 2, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RN075 Support for Removed deprecated ReactMethod in Android.
4 participants