Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fontawesome dependency from example app #6184

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

szarbartosz
Copy link
Contributor

@szarbartosz szarbartosz commented Jun 28, 2024

Summary

I noticed that @fontawesome dependency is present in the repository but is used in 2 demo screens only - the size of unpacked dependencies are following:

  • @fortawesome/fontawesome-svg-core: 397 kB
  • @fortawesome/free-solid-svg-icons: 5.09 MB
  • @fortawesome/react-native-fontawesome: 33.4 kB

I believe that plain text emojis (which are present on eg. examples list) could be used instead of fontawesome icons.

Test plan

Open Tab bar and Habits example from the example app

@szarbartosz szarbartosz changed the title Remove @fontawesome dependency Remove fontawesome dependency Jun 28, 2024
Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if these icons aren't bundled to the production reanimated package (I believe they aren't) then this change doesn't impact anything

comparing: development hermes engine weights over 1 GB and it doesn't matter

why we use fontawesome in the first place? i have no idea but for years we never have any problems with it

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After consulting on DMs

Removing fontawesome dependency makes it easier to port Reanimated to some out-of-tree platforms on which SVGs aren't fully supported yet which is a valid usecase for removing it from the example app

@kacperkapusciak kacperkapusciak changed the title Remove fontawesome dependency Remove fontawesome dependency from example app Jul 29, 2024
@kacperkapusciak kacperkapusciak added this pull request to the merge queue Jul 29, 2024
Merged via the queue into software-mansion:main with commit 015aa4b Jul 29, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants