Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the report at the mods portal, I have modified the pipe building to be based on the fluid box prototype instead being hardcoded.
I have done a couple of tests with the bigger AAI drills and it seems to be working fine. Unfortunately nobody in the mod portal forums offered test-feedback.
While I like the general structure of the new logic there are two places where I am unsure:
1.
local fluidbox_prototype = drill.fluidbox.get_prototype(1)
is this the way to get the correct fluid box, or would usinggame.entity_prototypes[drill.name]
(and then go to the members) be more correct...2.
autodeconstruct.build_pipe(drillData, pipeType, conn.positions[1])
... why has the fluidbox prototype an array for each connection even though the drill was only created with a single location for the connection. This seems strange but works...
I'll just open it as a pull request for now, maybe you can also have a look.
A pre-realease test package (zip) is available at https://github.com/nicolas-lang/AutoDeconstruct/releases
P.S. ( I was busy and the invite timed out)