Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IBDesignable and IBInspectable #13

Merged
merged 3 commits into from
Dec 16, 2015
Merged

Conversation

LeeroyDing
Copy link
Contributor

Supporting them will make life with storyboards easier.

This is a very simple approach without modifying anything. Any discussion is welcome.

@ninjinkun
Copy link

I tried this patch through Carthage. But it didn't work because IB annotations were striped from framework interoperability header GradientView-Swift.h. It seems Swift's bug. Same problems are here Carthage/Carthage#335 .
This patch maybe works without framework (add to project directly).

@soffes
Copy link
Owner

soffes commented Dec 16, 2015

Thanks! Can you remove all of those white space changes from your PR? Guessing those weren't on purpose.

@ninjinkun bummer. I guess people can just use submodules if they want to use this until this is fixed.

@LeeroyDing
Copy link
Contributor Author

I reversed the whitespace changes but kept one that changed the indention from white spaces to tabs, which stays in sync with other lines. No idea why this line was indented with space.

I wish Apple would make IBInspectable arrays possible, so it would be much more useful.

@soffes
Copy link
Owner

soffes commented Dec 16, 2015

Looks good! Thanks!

soffes added a commit that referenced this pull request Dec 16, 2015
Add IBDesignable and IBInspectable
@soffes soffes merged commit e22200a into soffes:master Dec 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants