-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SofaSparseSolver] Clean examples scenes of sparse linear solvers #2422
Conversation
…Components\linearsolver
[ci-build][with-all-tests] |
<Node name="M1"> | ||
<EulerImplicit name="cg_odesolver" printLog="false" rayleighStiffness="0.1" rayleighMass="0.1" /> | ||
<SparseLUSolver printLog="1" verbose="0" /> | ||
<EulerImplicitSolver name="cg_odesolver" printLog="false" rayleighStiffness="0.1" rayleighMass="0.1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I do not like seeing these rayleigh damping, especially in example scenes, but it's not the purpose of the PR ^^
<Node name="M1"> | ||
<EulerImplicit name="cg_odesolver" printLog="false" rayleighStiffness="0.1" rayleighMass="0.1" /> | ||
<SparseLUSolver printLog="1" verbose="0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well .. SVD you said? 😂
@@ -29,7 +29,7 @@ | |||
namespace sofa::component::linearsolver | |||
{ | |||
|
|||
//defaut structure for a LDL factorization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice copy-paste ..
Great work @alxbilger 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum sorry in fact FEMBAR-SVDLinearSolver.scn seems to time out: https://ci.inria.fr/sofa-ci-dev/job/sofa-framework/job/PR-2422/CI_CONFIG=macos_clang,CI_PLUGINS=options,CI_TYPE=release/3/SceneTestCrashes/
could you double check before merging.
[ci-build][with-all-tests] |
@epernod yes it makes sense as this solver is super slow. I'll change the number of iterations for this scene. Thanks |
lower your expectations! :) |
hum... otherwise we could considering ignoring this scene on the CI. |
Still timeout, even with only 1 iteration 😞 |
Remove collision components Add a scene for CGLinearSolver Set the right RequiredPlugin
…fa-framework#2422) * [SofaSparseSolver] Remove scenes as their equivalent are in examples\Components\linearsolver * [examples] Add example for PrecomputedLinearSolver * [examples] Add example for SVDLinearSolver * [SofaSparseSolver] msg_info without parameter * Cleaning * [examples] Speed up the example using multithreading * Turn multithreading on * [examples] Run only a few iterations to test FEMBAR-SVDLinearSolver.scn * Lower number of iterations * Clean scenes Remove collision components Add a scene for CGLinearSolver Set the right RequiredPlugin * ignore FEMBAR-SVDLinearSolver.scn on the CI
…fa-framework#2422) * [SofaSparseSolver] Remove scenes as their equivalent are in examples\Components\linearsolver * [examples] Add example for PrecomputedLinearSolver * [examples] Add example for SVDLinearSolver * [SofaSparseSolver] msg_info without parameter * Cleaning * [examples] Speed up the example using multithreading * Turn multithreading on * [examples] Run only a few iterations to test FEMBAR-SVDLinearSolver.scn * Lower number of iterations * Clean scenes Remove collision components Add a scene for CGLinearSolver Set the right RequiredPlugin * ignore FEMBAR-SVDLinearSolver.scn on the CI
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if