Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Make scene resolution independent + doc #2361

Merged

Conversation

alxbilger
Copy link
Contributor

The MechanicalMatrixMapper example scene deserved a bit of love.

  • Converted to Python3
  • Add documentation (the concept of rigidification deserves a more detailed doc somewhere else)
  • It is possible to change the resolution of the grid while keeping the same behavior: 1) indexPairs is built algorithmically, 2) ConstantForceField is applied using a BoxROI

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy
Copy link
Contributor

fredroy commented Sep 27, 2021

As it is using SofaPython3 to run, should not it be ... in the SofaPython3 plugin 😶 ?

@hugtalbot hugtalbot added pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request labels Sep 27, 2021
@alxbilger
Copy link
Contributor Author

For the record, the scene was already here before this PR, and it required Python...

There are pros and cons about putting Python scenes in SOFA. Let's discuss it.

For this scene in particular, Python is required as the scene has a Node with two parent Nodes. It also allows to compute indexPairs.

@fredroy
Copy link
Contributor

fredroy commented Sep 27, 2021

@alxbilger I understand your point, especially because it is the only scene showing an example on how to use MechanicalMatrixMapper...

@alxbilger alxbilger added the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Sep 28, 2021
@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Sep 28, 2021
@guparan guparan merged commit 659c8db into sofa-framework:master Sep 28, 2021
@guparan guparan added this to the v21.12 milestone Oct 1, 2021
damienmarchal pushed a commit to CRIStAL-PADR/sofa that referenced this pull request Oct 11, 2021
@alxbilger alxbilger deleted the mechanicalmatrixmapperscene branch June 28, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: clean Cleaning the code pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants