Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaHelper] drawFakeSphere: fix ambient component in shaders #192

Merged
merged 1 commit into from
Mar 8, 2017
Merged

[SofaHelper] drawFakeSphere: fix ambient component in shaders #192

merged 1 commit into from
Mar 8, 2017

Conversation

fredroy
Copy link
Contributor

@fredroy fredroy commented Mar 3, 2017 •
edited by damienmarchal
Loading

Small patch to restore ambient component in fake sphere rendering.

Was:
manyspheres_00000002

Now:
manyspheres_00000001

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings nor unit test failures.
  • does not break existing scenes.
  • does not break API compatibility.
  • has been reviewed
  • is more than 1 week old.

Reviewers will merge only if all these checks are true.

@fredroy fredroy added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug labels Mar 3, 2017
@fredroy fredroy mentioned this pull request Mar 3, 2017
Merged
6 tasks
@matthieu-nesme
Copy link
Member

wahoo, a description with pictures, that's a first!

@matthieu-nesme matthieu-nesme merged commit 5ea6428 into sofa-framework:master Mar 8, 2017
@guparan guparan added this to the v17.06 milestone Jun 29, 2017
@fredroy fredroy deleted the fix_ambient_rendering branch September 14, 2017 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: fix Fix a bug
Projects
None yet
Milestone
v17.06
Development

Successfully merging this pull request may close these issues.
3 participants
@fredroy @matthieu-nesme @guparan