-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[all] Speed up spheres rendering + code cleaning (URGENT) #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l likely display a lot of spheres)
spheres and impostors
damienmarchal
changed the title
Speed up spheres rendering
[all] Speed up spheres rendering + code cleaning
Feb 14, 2017
YEAH! Thanks Fred, do we have to wait for a week before merging? |
damienmarchal
changed the title
[all] Speed up spheres rendering + code cleaning
[all] Speed up spheres rendering + code cleaning (URGENT)
Feb 15, 2017
[ci-build] |
1 similar comment
[ci-build] |
@fredroy It is working well, one minor problem is the spheres are darker, is it possible to tweak the shader to display them lighter by default? Thanks. |
You are right that the spheres are too dark ; I forgot to add the ambient component in the final color computation ; I will submit a patch right away. |
Pull-Request : #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up by a (huge) factor the rendering of several spheres.
This is done in 2 ways:
On the same computer, for 150K spheres :
This task is also the beginning of optimizing draw tools, by removing deprecated glu calls and non optimized OpenGL code ; and by using VBO/IBO and shaders. (class BasicShapesGL)
This PR should resolve more or less the issue #142 .
It depends if this issue talks about spheres only or more generally speeding up rendering itself (in that case, it will need much more commits ;) )
This PR:
Reviewers will merge only if all these checks are true.